Fixed grammar issue in console.rst #10144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 3, 2018
console.rst
Outdated
| @@ -200,7 +200,7 @@ Now, you can pass the username to the command: | |||
| Getting Services from the Service Container | |||
| ------------------------------------------- | |||
|
|
|||
| To actually create a new user, the command has to access to some | |||
| To actually create a new user, the command has to have access to some | |||
There was a problem hiding this comment.
In 2.8, the sentence reads like this: "[...] has to access some [...]" Shouldn't we changed it here accordingly?
There was a problem hiding this comment.
Oh, I see. Yes, I prefer 2.8's wording.
xabbuh
approved these changes
Aug 3, 2018
|
Thank you @Vafilor. |
xabbuh
added a commit
that referenced
this pull request
Aug 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.